MAINT: update license handling for PEP 639 change#5
Merged
Conversation
xref numpy#29535, which contains the same change
Member
|
Should we add a check that the files here are the same as the ones in the numpy/numpy repo? |
Member
Author
If you mean the LGPL ones for vendored code: I'm about to open a PR to remove them from the |
Member
|
I meant the actual files in this PR, see also #6 |
Member
Author
|
I'll go ahead and merge this, because it's trivially correct and necessary for the build to pass. The comment on keeping things in sync is being worked on in gh-6 and the PR linking to that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref numpy/numpy#29535, which contains the same change
Closes gh-4