🏷️ tighten _NestedSequence#713
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tightens the type annotations for _NestedSequence protocol and cleans up imports/type variable declarations in the NumPy stubs. The changes focus on improving type safety and code organization.
- Updates
_NestedSequenceprotocol with more precise iterator return types and adds@finaldecorator - Reorganizes type variable declarations and removes unused imports in
_linalg.pyi - Removes unnecessary
# type: ignore[overload-overlap]comments from function overloads
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/numpy-stubs/_typing/_nested_sequence.pyi | Adds @final decorator and refines iterator return types for better type safety |
| src/numpy-stubs/linalg/_linalg.pyi | Cleans up imports, reorganizes type variables, and removes type ignore comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.