Skip to content

🏷️ tighten _NestedSequence#713

Merged
jorenham merged 2 commits into
mainfrom
tighter-NestedSequence
Sep 19, 2025
Merged

🏷️ tighten _NestedSequence#713
jorenham merged 2 commits into
mainfrom
tighter-NestedSequence

Conversation

@jorenham
Copy link
Copy Markdown
Member

No description provided.

@jorenham jorenham requested a review from Copilot September 19, 2025 10:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tightens the type annotations for _NestedSequence protocol and cleans up imports/type variable declarations in the NumPy stubs. The changes focus on improving type safety and code organization.

  • Updates _NestedSequence protocol with more precise iterator return types and adds @final decorator
  • Reorganizes type variable declarations and removes unused imports in _linalg.pyi
  • Removes unnecessary # type: ignore[overload-overlap] comments from function overloads

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/numpy-stubs/_typing/_nested_sequence.pyi Adds @final decorator and refines iterator return types for better type safety
src/numpy-stubs/linalg/_linalg.pyi Cleans up imports, reorganizes type variables, and removes type ignore comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/numpy-stubs/_typing/_nested_sequence.pyi
@jorenham jorenham merged commit 0409dd8 into main Sep 19, 2025
20 checks passed
@jorenham jorenham deleted the tighter-NestedSequence branch September 19, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants