resolve: GOWORK=off + passAsFile importcfg_entries (dynamic-mode torture fixes)#125
Merged
brianmcgee merged 1 commit intomainfrom Apr 16, 2026
Merged
resolve: GOWORK=off + passAsFile importcfg_entries (dynamic-mode torture fixes)#125brianmcgee merged 1 commit intomainfrom
brianmcgee merged 1 commit intomainfrom
Conversation
The dag-mode plugin sets GOWORK=off (resolve.rs:382); dynamic-mode resolve.go didn't. With a go.work present, workspace MVS ignores per-module replace directives, so it may select a version the per-module lockfile doesn't have. The torture fixture (which gained go.work in #121 for gazelle) hits this with gin v1.9.1 (replace) vs v1.12.0 (workspace MVS). :house: Remote-Dev: homespace
5 tasks
brianmcgee
approved these changes
Apr 16, 2026
Benchmark Regression Check
Baseline: |
aldoborrero
changed the title
This was referenced Apr 16, 2026
resolve: passAsFile importcfg_entries (dynamic-mode link drv exceeds MAX_ARG_STRLEN on torture)
#127
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic-mode
resolve.godidn't setGOWORK=off; the dag plugin does (resolve.rs:382). With ago.workpresent, workspace MVS ignores per-modulereplacedirectives, so it may select a version the per-module lockfile doesn't have —go list -mod=readonlythen fails withmodule lookup disabled by GOPROXY=off. The torture fixture (which gainedgo.workin #121 for gazelle) hits this:app-fullreplaces gin → v1.9.1, workspace MVS picks v1.12.0 frominternal/web.Unblocks #124's torture×dynamic comparison.