Merged
Conversation
jfly
reviewed
Feb 2, 2026
Collaborator
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Could you add a test?
bitbloxhub
force-pushed
the
ignore-submodules
branch
2 times, most recently
from
97b3f19 to
811fe18
Compare
jfly
reviewed
Feb 2, 2026
|
|
||
| // 160000 is the mode for submodules | ||
| if strings.HasPrefix(stage, "160000") { | ||
| g.scanner.Scan() |
Collaborator
There was a problem hiding this comment.
I don't understand why we need this here. Won't the for loop do the right thing when we continue?
Contributor
Author
There was a problem hiding this comment.
No, because this loop just calls g.scanner.Text(), and g.scanner.Scan() is called in the outer loop (the one we call nextFile in). If you want, I could refactor it so we call Scan in the nextFile function.
Collaborator
There was a problem hiding this comment.
Ohhh, got it. Your call, whatever you prefer.
Contributor
Author
There was a problem hiding this comment.
Can't get the refactor to work, so I guess we can just leave this here for now.
bitbloxhub
force-pushed
the
ignore-submodules
branch
from
811fe18 to
c80829b
Compare
jfly
approved these changes
Feb 2, 2026
Collaborator
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Thanks for adding the test! LGTM
bitbloxhub
force-pushed
the
ignore-submodules
branch
from
c80829b to
b96016b
Compare
brianmcgee
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154.