Skip to content

[16.0][FIX] connector_lighting_sapb1: convert ibox_volume per SAP SVolUnit#98

Merged
eantones merged 1 commit into
16.0from
16.0-fix-connector_lighting_sapb1-volume_unit_conversion
May 14, 2026
Merged

[16.0][FIX] connector_lighting_sapb1: convert ibox_volume per SAP SVolUnit#98
eantones merged 1 commit into
16.0from
16.0-fix-connector_lighting_sapb1-volume_unit_conversion

Conversation

@deeniiz
Copy link
Copy Markdown
Collaborator

@deeniiz deeniiz commented Apr 27, 2026

The previous code multiplied SVolume by 1000 unconditionally, assuming all products use dm³ (SVolUnit=3). SAP B1 stores volumes in three different units (dm³, cm³, m³), producing 1000× inflated values for the non-dm³ products. SVolUnit is now read from SAP, included in the row hash so existing products are re-imported, and used to pick the correct multiplier into cm³ (the unit of lighting.product.ibox_volume).

The previous code multiplied SVolume by 1000 unconditionally, assuming
all products use dm³ (SVolUnit=3). SAP B1 stores volumes in three
different units (dm³, cm³, m³), producing 1000× inflated values for the
non-dm³ products. SVolUnit is now read from SAP, included in the row
hash so existing products are re-imported, and used to pick the correct
multiplier into cm³ (the unit of lighting.product.ibox_volume).
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.55%. Comparing base (26b0b02) to head (100453b).
⚠️ Report is 7 commits behind head on 16.0.

Files with missing lines Patch % Lines
...ing_sapb1/models/lighting_product/import_mapper.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0      #98      +/-   ##
==========================================
- Coverage   43.60%   43.55%   -0.06%     
==========================================
  Files         283      283              
  Lines        8104     8132      +28     
  Branches     1564     1571       +7     
==========================================
+ Hits         3534     3542       +8     
- Misses       4475     4495      +20     
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deeniiz deeniiz requested a review from eantones April 27, 2026 11:41
@deeniiz deeniiz added the to review Must be reviewed label Apr 27, 2026
@eantones eantones merged commit ee9236b into 16.0 May 14, 2026
4 of 6 checks passed
@eantones eantones deleted the 16.0-fix-connector_lighting_sapb1-volume_unit_conversion branch May 14, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to review Must be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants