[16.0][REF] lighting: is_spare_part now category-derived (symmetric with is_accessory)

[eantones]

Summary

Refactor is_spare_part on lighting.product to follow the same pattern as is_accessory — derived from the category. Adds the missing categorical flag that accessories already have, bringing spare-parts to full symmetry: 1 categorical + 1 relational (versus accessories' 1 categorical + 2 relational, one per m2m kind).

Before this refactor

is_accessory                ← categorical (from category_id._get_is_accessory)
is_optional_accessory       ← relational  (m2m optional_ids inverse)
is_required_accessory       ← relational  (m2m required_ids inverse)
is_spare_part               ← relational  (m2m spare_part_ids inverse)
                              ↑ missing the categorical equivalent

[('is_spare_part', '=', True)] returned only items already linked somewhere as spare parts — never the broader universe of categorically-spare items. That made the "Spare parts" search filter on the product list useless for browsing the spare-parts universe.

After this refactor

is_accessory                ← categorical (from category)
is_optional_accessory       ← relational
is_required_accessory       ← relational
is_spare_part               ← categorical (from category — NEW)
is_used_as_spare_part       ← relational  (m2m spare_part_ids inverse — RENAMED from previous is_spare_part)

Both Booleans coexist, both useful. The existing search filter now returns the universe of categorically-spare products — the intended user-facing behavior.

Changes

lighting/models/product_category.py

• NEW: stored Boolean is_spare_part next to the existing is_accessory (line 59).
• NEW: recursive walker _get_is_spare_part(self) next to _get_is_accessory — same parent-chain semantics.

lighting/models/product.py

• NEW: computed Boolean is_spare_part (categorical) right after _search_is_accessory (line 557). Compute via category_id._get_is_spare_part(). Direct mirror of is_accessory / _compute_is_accessory / _search_is_accessory.
• RENAME: existing is_spare_part (m2m-derived) → is_used_as_spare_part. Compute/search logic unchanged, just the field/method names. Original semantics preserved under the more accurate name.

lighting/views/product_category_views.xml

• Add <field name="is_spare_part" /> next to <field name="is_accessory" /> on both the form view (line 89) and the list view (line 158).

Translations

• i18n/es.po, i18n/fr.po, i18n/pt.po: updated. Old Is spare part msgid replaced by the auto-derived Is Spare Part (now shared between the product and category fields) + new Is used as spare part for the renamed field.
• i18n/ca.po: created (was previously missing — required per NuoBiT convention).

lighting/__manifest__.py

• Version bumped 16.0.1.0.0 → 16.0.1.1.0 (minor).

Migration

No data migration script required.

• The lighting_product_spare_part_rel m2m table is unchanged. The renamed is_used_as_spare_part field uses the same compute/search logic as before, reading the same rows.
• The new is_spare_part Boolean on lighting.product.category is a stored column that Odoo auto-adds on -u lighting. Defaults to False — no observable change for existing customers unless they explicitly flag a category.
• All other changes are computed fields with no DB column footprint.

Behavioral change for downstream consumers

• A single in-codebase domain consumer exists: the search filter [('is_spare_part', '=', True)] in lighting/views/product_views.xml:825. After this refactor, the filter intentionally returns the categorical universe instead of the relational subset. This is the intended user-facing behavior.
• No other modules in the addons tree reference is_spare_part.
• External customers using is_spare_part in custom code/views will get the categorical semantics. The relational semantics are still available via the renamed is_used_as_spare_part field — a one-line search/replace migration path.

Test plan

• -u lighting on a database that previously installed this module — verify the new column is added, no exceptions.
• Create a lighting.product.category with is_spare_part=True.
• Create a child category under it (no is_spare_part set) and a lighting.product whose category_id is the child.
• Verify the product has is_spare_part=True (inherited via the parent-chain walker).
• Verify the search filter domain="[('is_spare_part', '=', True)]" returns the product.
• Manually link two products via spare_part_ids — verify is_used_as_spare_part=True on the linked product.
• Verify the smart button parent_spare_part_product_count still works on the linked product (uses the m2m count directly, independent of the renamed flag).

[codecov]

Codecov Report

❌ Patch coverage is 36.36364% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.52%. Comparing base (077dd16) to head (e19d40e).

Files with missing lines	Patch %	Lines
lighting/models/product.py	39.13%	13 Missing and 1 partial ⚠️
lighting/models/product_category.py	30.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             16.0      #99      +/-   ##
==========================================
- Coverage   43.56%   43.52%   -0.05%     
==========================================
  Files         283      283              
  Lines        8130     8157      +27     
  Branches     1570     1579       +9     
==========================================
+ Hits         3542     3550       +8     
- Misses       4493     4511      +18     
- Partials       95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.