[16.0][FIX] sale_order_report_zero_qty: handle section/note lines#899
Open
deeniiz wants to merge 1 commit into
Open
[16.0][FIX] sale_order_report_zero_qty: handle section/note lines#899deeniiz wants to merge 1 commit into
deeniiz wants to merge 1 commit into
Conversation
Section and note lines (display_type) have no product_uom, so product_uom.rounding evaluates to 0.0 and float_is_zero raises "precision_rounding must be positive". Skip the qty check for these lines so they always render in the report.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #899 +/- ##
=======================================
Coverage 43.79% 43.79%
=======================================
Files 325 325
Lines 6464 6464
Branches 1011 1011
=======================================
Hits 2831 2831
Misses 3612 3612
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f69807 to
12f28c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section and note lines (display_type) have no product_uom, so product_uom.rounding evaluates to 0.0 and float_is_zero raises "precision_rounding must be positive". Skip the qty check for these lines so they always render in the report.