feat: support enabling services in google and azure#4
Draft
jordan-acosta wants to merge 3 commits into
Draft
Conversation
b594fb6 to
9d96be2
Compare
9d96be2 to
021e2e7
Compare
Optionally pass in a list of google services to enable.
021e2e7 to
2636fe3
Compare
Convert Azure ARM template resources (vnet, runner VMSS) to Terraform, mirroring the GCP module structure with IAM, secrets, phone home, and configurable networking. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a services variable to register Azure resource providers via azurerm_resource_provider_registration, matching the GCP module pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Services in GCP must be enabled before you can use them. This can make installing an app in a customer's cloud challenging, because the customer has control over the services, but the vendor knows what services are required. We need a way for the vendor to formally share what services need to be enabled before installing the app, and a way for the customer to easily review and enable them.
Azure presents a similar challenge with resource providers.
Solution
This adds a "services" variable to the GCP, that accepts a list of services to enable. When the customer applies the stack, the customer will the services in the Terraform plan, and they will be enabled by simply applying the stack.
We're not using Terraform for the azure stack, but this PR also includes a prototype of the azure stack in terraform, with resource provider registration supported.