Skip to content

fix: specify target branch for linting changed charts #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuxtof merged 1 commit into from
Feb 6, 2026
Merged

fix: specify target branch for linting changed charts #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/linting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Linting Charts

on:
push
on: push

jobs:
linting:
Expand All @@ -18,13 +17,13 @@ jobs:
- name: Run chart-testing (lint-changed)
id: list-changed
run: |
changed=$(ct list-changed)
changed=$(ct list-changed --target-branch master)
if [[ -n "$changed" ]]; then
echo "::set-output name=changed::true"
fi

- name: Run chart-testing (lint)
run: ct lint
run: ct lint --target-branch master

- name: ArtifactHUB Lint
env:
Expand All @@ -33,4 +32,3 @@ jobs:
curl -LO https://github.com/artifacthub/hub/releases/download/v${AH_CLI_VERSION}/ah_${AH_CLI_VERSION}_linux_amd64.tar.gz
tar xvzf ah_${AH_CLI_VERSION}_linux_amd64.tar.gz
./ah lint

6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
- name: Run chart-testing (lint-changed)
id: list-changed
run: |
changed=$(ct list-changed)
changed=$(ct list-changed --target-branch master)
if [[ -n "$changed" ]]; then
echo "::set-output name=changed::true"
fi

- name: Run chart-testing (lint)
run: ct lint
run: ct lint --target-branch master

- name: Create k8s Kind Cluster
uses: helm/kind-action@v1.13.0
Expand All @@ -39,4 +39,4 @@ jobs:
helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --set installCRDs=true --wait

- name: Run chart-testing (install)
run: ct install --helm-extra-set-args "--set=kindtest=true"
run: ct install --target-branch master --helm-extra-set-args "--set=kindtest=true"
Loading