Open
Conversation
Contributor
|
The original issue is now fixed. I am not sure we need any of the other changes, as bounding box itself can be calculated from tile mask and is thus redundant. Also, the original script is quite fast when used with pypy, which is the recommended Python implementation when processing offline packages. |
Author
|
@mtehver i ll test your new implementation and report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So as i mentionned here #2
with sub osm extract the valhalla build scripts seems to be looking for the wrong tiles.
I fixed in the way :
It is also much faster as building tiles list from tilemask seems pretty slow.
In this case it means the tilemask is actually not needed anymore.
There is also code cleanup of consequently unecessary code and a VACUUM cleanup