Skip to content

Fixes for CI workflow#23

Merged
seanbudd merged 5 commits intonvaccess:masterfrom
CyrilleB79:ciFix
Mar 17, 2026
Merged

Fixes for CI workflow#23
seanbudd merged 5 commits intonvaccess:masterfrom
CyrilleB79:ciFix

Conversation

@CyrilleB79
Copy link

Changes

Various CI fixes and improvements:

Tests

Testing done in https://github.com/CyrilleB79/AddonTemplateTest/, release V1.0

@CyrilleB79
Copy link
Author

@nvdaes, I’d really appreciate your review, especially regarding the use of uv. I’m fairly new to it, so a second check would be valuable.
@josephsl, your review would also be appreciated if you have the bandwidth, though I understand you’ve recently reduced / deprioritized NVDA work.

@nvdaes
Copy link

nvdaes commented Mar 16, 2026

Thanks @CyrilleB79 . I'll review it ASAP, probably tomorrow. Today I am affected by influenza or some kind of virus, but I don't think this is important and probably tomorrow I will be better.

@CyrilleB79
Copy link
Author

No problem, feel free to review when you can. Wish you get better soon.

@seanbudd
Copy link
Member

@nvdaes - I'm happy to merge as-is, but did you want to check it as well?

@seanbudd seanbudd self-assigned this Mar 17, 2026
Copy link

@nvdaes nvdaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79 and @seanbudd . LGTM

@seanbudd seanbudd merged commit e0585fd into nvaccess:master Mar 17, 2026
3 checks passed
@CyrilleB79 CyrilleB79 deleted the ciFix branch March 17, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants