Merged
Conversation
Author
|
Thanks @CyrilleB79 . I'll review it ASAP, probably tomorrow. Today I am affected by influenza or some kind of virus, but I don't think this is important and probably tomorrow I will be better. |
Author
|
No problem, feel free to review when you can. Wish you get better soon. |
seanbudd
approved these changes
Mar 17, 2026
Member
|
@nvdaes - I'm happy to merge as-is, but did you want to check it as well? |
nvdaes
approved these changes
Mar 17, 2026
nvdaes
left a comment
There was a problem hiding this comment.
Thanks @CyrilleB79 and @seanbudd . LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Various CI fixes and improvements:
Tests
Testing done in https://github.com/CyrilleB79/AddonTemplateTest/, release V1.0