AuthTokenHandler to always send an auth header unless specified otherwise

[fperreaultnv]

GitHub Issue: #62

Proposed Changes

• Feature

What is the current behavior?

AuthenticationTokenHandler does not include a token if the request doesn't already contain an Auth header.

What is the new behavior?

AuthenticationTokenHandler always includes a token unless it finds Authorization: Anonymous in the headers.

Checklist

• Documentation has been added/updated
• Automated Unit / Integration tests for the changes have been added/updated
• Contains NO breaking changes
• Updated the Changelog
• Associated with an issue

[jeanplevesque]

I unchecked Contains NO breaking changes because this PR currently reverses a default behavior which will break all applications using AuthenticationTokenHandler.
I wonder if we should keep the default behavior AND introduce a new class with the behavior that you want?

[jeanplevesque]

I unchecked Contains NO breaking changes because this PR currently reverses a default behavior which will break all applications using AuthenticationTokenHandler.
I wonder if we should keep the default behavior AND introduce a new class with the behavior that you want?

Note however that the breaking change is probably going to be silent... meaning that it will provide a header that wasn't provided previously, which shouldn't actually break functionalities.
In any case, it's still a breaking change because the behavior changes.

[fperreaultnv]

I unchecked Contains NO breaking changes because this PR currently reverses a default behavior which will break all applications using AuthenticationTokenHandler.
I wonder if we should keep the default behavior AND introduce a new class with the behavior that you want?

As you mentioned, it's a breaking change that doesn't break anything. The behavior is subtly different, yes, but I believe this is more of a fix to an undesirable behavior rather than a completely different implementation. Apps don't even have to react to this change, or very slightly if they desire not to try to send an auth header when sending a login request (for example), by adding [Headers("Authorization: Anonymous")] instead of nothing.

Let me know what you think.

[Soap-141]

@jeanplevesque Should we close this?