fixes: Use default IOCQES/IOSQES upon device enable#42
Open
gersner wants to merge 1 commit intonvmecompliance:masterfrom
Open
fixes: Use default IOCQES/IOSQES upon device enable#42gersner wants to merge 1 commit intonvmecompliance:masterfrom
gersner wants to merge 1 commit intonvmecompliance:masterfrom
Conversation
Specification requires that CC.IOCQES and CC.IOSQES are configured prior to device enbale using CC.EN. Invalid value will lead to failure to initialize device. When device properly implements Controller Reset, hence clearing of CC, this will lead to unexpected test failures. The following change adds default minimal values prior to enabling the device. Values are taken from specification and same approach is used in nvme driver in the linux kernel. Signed-off-by: Shimi Gersner <gersner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification requires that CC.IOCQES and CC.IOSQES are
configured prior to device enbale using CC.EN. Invalid value
will lead to failure to initialize device.
When device properly implements Controller Reset, hence clearing of
CC, this will lead to unexpected test failures.
The following change adds default minimal values prior to
enabling the device. Values are taken from specification
and same approach is used in nvme driver in the linux kernel.
Signed-off-by: Shimi Gersner gersner@gmail.com