autovideoconvert: add imxvideoconvert_g2d#2
Open
hiagofranco wants to merge 1 commit into
Open
Conversation
On i.MX8 platform, autovideoconvert defaults to CPU-based processing as imxvideoconvert_g2d is not included as a listed filter, resulting in poor video playback performance. Add imxvideoconvert_g2d to improve performance by utilizing hardware acceleration. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
junzhuimx
pushed a commit
that referenced
this pull request
Sep 15, 2025
This is a regression caused by commit ce8c183. Thread 11 holds window_lock and is waiting for sync_mutex, while thread 2 holds sync_mutex and is waiting for window_lock. It causes dead lock. To fix it, no need to add window lock when destroy commit_callback. Thread 11 (Thread 0xffff807be160 (LWP 898) "GstPlay"): \#0 futex_wait (futex_word=0xffff60003e10, expected=2, private=0) at /usr/src/debug/glibc/2.41+git/sysdeps/nptl/futex-internal.h:146 \#1 __GI___lll_lock_wait (futex=futex@entry=0xffff60003e10, private=private@entry=0) at lowlevellock.c:49 \#2 0x0000ffff81113c08 in lll_mutex_lock_optimized (mutex=0xffff60003e10) at pthread_mutex_lock.c:48 \#3 ___pthread_mutex_lock (mutex=0xffff60003e10) at pthread_mutex_lock.c:128 \#4 0x0000ffff808fab94 in gst_wl_display_object_destroy (self=<optimized out>, object=0xffff58002140, destroy_func=0xffff808f9448 <wl_callback_destroy>) at ../gst-libs/gst/wayland/gstwldisplay.c:724 \#5 0x0000ffff808fabd0 in gst_wl_display_callback_destroy (self=<optimized out>, callback=<optimized out>) at ../gst-libs/gst/wayland/gstwldisplay.c:744 \#6 0x0000ffff808fdcd8 in gst_wl_window_finalize (gobject=0xffff58002180) at ../gst-libs/gst/wayland/gstwlwindow.c:421 Thread 2 (Thread 0xffff677ef160 (LWP 970) "GstWlDisplay"): \#0 syscall () at ../sysdeps/unix/sysv/linux/aarch64/syscall.S:38 \#1 0x0000ffff81320fb4 in ?? () from /usr/lib/libglib-2.0.so.0 \#2 0x0000ffff808fe42c in commit_callback (data=0xffff58002180, callback=<optimized out>, serial=<optimized out>) at ../gst-libs/gst/wayland/gstwlwindow.c:976 \#3 0x0000ffff80e768d4 in ?? () from /usr/lib/libffi.so.8 \#4 0x0000ffff80e75fdc in ?? () from /usr/lib/libffi.so.8 \#5 0x0000ffff8089a604 in ?? () from /usr/lib/libwayland-client.so.0 \#6 0x0000ffff80896430 in ?? () from /usr/lib/libwayland-client.so.0 \#7 0x0000ffff808976d8 in wl_display_dispatch_queue_pending () from /usr/lib/libwayland-client.so.0 \#8 0x0000ffff808f9530 in gst_wl_display_thread_run (data=<optimized out>) at ../gst-libs/gst/wayland/gstwldisplay.c:534
junzhuimx
pushed a commit
that referenced
this pull request
Dec 4, 2025
This is a regression caused by commit ce8c183. Thread 11 holds window_lock and is waiting for sync_mutex, while thread 2 holds sync_mutex and is waiting for window_lock. It causes dead lock. To fix it, no need to add window lock when destroy commit_callback. Thread 11 (Thread 0xffff807be160 (LWP 898) "GstPlay"): \#0 futex_wait (futex_word=0xffff60003e10, expected=2, private=0) at /usr/src/debug/glibc/2.41+git/sysdeps/nptl/futex-internal.h:146 \#1 __GI___lll_lock_wait (futex=futex@entry=0xffff60003e10, private=private@entry=0) at lowlevellock.c:49 \#2 0x0000ffff81113c08 in lll_mutex_lock_optimized (mutex=0xffff60003e10) at pthread_mutex_lock.c:48 \#3 ___pthread_mutex_lock (mutex=0xffff60003e10) at pthread_mutex_lock.c:128 \#4 0x0000ffff808fab94 in gst_wl_display_object_destroy (self=<optimized out>, object=0xffff58002140, destroy_func=0xffff808f9448 <wl_callback_destroy>) at ../gst-libs/gst/wayland/gstwldisplay.c:724 \#5 0x0000ffff808fabd0 in gst_wl_display_callback_destroy (self=<optimized out>, callback=<optimized out>) at ../gst-libs/gst/wayland/gstwldisplay.c:744 \#6 0x0000ffff808fdcd8 in gst_wl_window_finalize (gobject=0xffff58002180) at ../gst-libs/gst/wayland/gstwlwindow.c:421 Thread 2 (Thread 0xffff677ef160 (LWP 970) "GstWlDisplay"): \#0 syscall () at ../sysdeps/unix/sysv/linux/aarch64/syscall.S:38 \#1 0x0000ffff81320fb4 in ?? () from /usr/lib/libglib-2.0.so.0 \#2 0x0000ffff808fe42c in commit_callback (data=0xffff58002180, callback=<optimized out>, serial=<optimized out>) at ../gst-libs/gst/wayland/gstwlwindow.c:976 \#3 0x0000ffff80e768d4 in ?? () from /usr/lib/libffi.so.8 \#4 0x0000ffff80e75fdc in ?? () from /usr/lib/libffi.so.8 \#5 0x0000ffff8089a604 in ?? () from /usr/lib/libwayland-client.so.0 \#6 0x0000ffff80896430 in ?? () from /usr/lib/libwayland-client.so.0 \#7 0x0000ffff808976d8 in wl_display_dispatch_queue_pending () from /usr/lib/libwayland-client.so.0 \#8 0x0000ffff808f9530 in gst_wl_display_thread_run (data=<optimized out>) at ../gst-libs/gst/wayland/gstwldisplay.c:534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On i.MX8 platform, autovideoconvert defaults to CPU-based processing as imxvideoconvert_g2d is not included as a listed filter, resulting in poor video playback performance.
Add imxvideoconvert_g2d to improve performance by utilizing hardware acceleration.