chore: update all dependencies to latest versions#79
Conversation
- @clack/prompts 1.2.0 → 1.3.0 - tinyglobby 0.2.15 → 0.2.16 - @changesets/cli 2.30.0 → 2.31.0 - @types/node 24.12.2 → 25.6.0 - @typescript/native-preview 7.0.0-dev.20260406.1 → 7.0.0-dev.20260430.1 - @vitest/coverage-v8 4.1.2 → 4.1.5 - knip 6.3.0 → 6.9.0 - lefthook 2.1.5 → 2.1.6 - oxfmt → 0.47.0 - oxlint → 1.62.0 - tsdown 0.21.7 → 0.21.10 - tuistory 0.0.16 → 0.3.0 - ultracite 7.4.3 → 7.6.2 - vitest 4.1.2 → 4.1.5 https://claude.ai/code/session_01FcE75wKqeFyMsvmLg787q9
|
|
Size Change: 0 B Total Size: 3.05 kB ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies and devDependencies in package.json, including @clack/prompts, tinyglobby, and vitest. A concern was raised regarding the @types/node update, as the new version exceeds the minimum Node.js version specified in the engines field, which could lead to runtime errors if unsupported APIs are utilized.
| "@typescript/native-preview": "7.0.0-dev.20260406.1", | ||
| "@vitest/coverage-v8": "4.1.2", | ||
| "@changesets/cli": "2.31.0", | ||
| "@types/node": "25.6.0", |
There was a problem hiding this comment.
The @types/node version (25.6.0) is ahead of the minimum supported Node.js version (>=24.14.0) specified in the engines field. This mismatch can lead to the use of APIs that are available in the type definitions but missing in the target runtime, potentially causing runtime errors that the compiler will not catch. It is recommended to keep @types/node aligned with the major version of the minimum supported Node.js environment. Additionally, ensure that .node-versions is used for exact pinning while the engines field in package.json uses a less restrictive SemVer range for broader compatibility.
| "@types/node": "25.6.0", | |
| "@types/node": "24.12.2", |
References
- For Node.js versioning, use .node-versions for exact pinning and a less restrictive SemVer range in package.json's engines field for broader compatibility.
ultracite 7.6.2 removed JSON config files in favour of JS/TS flat config exports. Replace the broken `.oxlintrc.json` (which extended a now-missing JSON path) with `oxlint.config.ts` using the new `defineConfig` API. - Delete `.oxlintrc.json` - Add `oxlint.config.ts` extending `ultracite/oxlint/core` with vitest overrides inlined to preserve full rule control - Fix `unicorn/prefer-import-meta-properties`: use `import.meta.dirname` instead of `dirname(fileURLToPath(import.meta.url))` in e2e test - Fix `vitest/require-mock-type-parameters`: add explicit type parameters to `vi.fn()` calls in cli.test.ts and runner.test.ts - Disable `vitest/prefer-importing-vitest-globals` (project uses globals: true) https://claude.ai/code/session_01FcE75wKqeFyMsvmLg787q9
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a01a3463e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,106 @@ | |||
| import { defineConfig } from "oxlint"; | |||
| import coreConfig from "ultracite/oxlint/core"; | |||
There was a problem hiding this comment.
Importing ultracite/oxlint/core as a bare ESM import can break linting because that subpath resolves to a JSON config file, and Node requires a JSON import attribute. In this state, ultracite check/oxlint can fail at config load time with ERR_IMPORT_ATTRIBUTE_MISSING, which blocks the repository’s pnpm check workflow before any lint rules run.
Useful? React with 👍 / 👎.
2 participants
https://claude.ai/code/session_01FcE75wKqeFyMsvmLg787q9