Guard findNodeKeyUp against out-of-range positions#162
Merged
Conversation
saranrapjs
reviewed
Apr 1, 2026
| const pluginState = reactPluginKey.getState(editorView.state); | ||
| if (!pluginState) return ROOT_NODE_KEY; | ||
|
|
||
| if (pos < 0) return ROOT_NODE_KEY; |
Member
There was a problem hiding this comment.
can you add a comment here about the -1 sentinel/why we have this check?
Member
There was a problem hiding this comment.
agree, also we could make this slightly more self-explanatory by doing an equality check to -1. but that's a nit.
Member
|
I think we use the yarn berry release process (e.g. |
saranrapjs
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
findNodeKeyUpcallsdoc.resolve(pos)without validating that pos is within the document bounds, causing a "RangeError: Position -1 out of range" crash when a node view'sgetPos()returns -1 (the standard sentinel for nodes that are no longer part of the document)Fix
This PR adds a bounds check
pos < 0that returnsROOT_NODE_KEYearly, if the node has no valid position, there are no ancestors to find