Participants page & Transcripts page UX#104
Conversation
…and no participants selected (like transcript-count, this query is unsupported)
- Don't make down-triangle go away if a non-first option is selected - Make ranges a little smaller
…tributes (which tend to be small files & fast exports)
|
Hang on--I forgot to check that 54f979a worked. Filling in an episode yields "invalid query". Maybe that's why it was commented out with TODO before! |
| transcriptDescription = ""; // Human readable description of transcript query | ||
| defaultTranscriptFilter = ""; | ||
| // hints for 'system layers' | ||
| participantLayerHint = "Participant"; |
There was a problem hiding this comment.
These should all be tagged with // TODO i18n
| participant="{{true}}" transcript="{{true}}" | ||
| span="{{true}}" phrase="{{true}}" word="{{true}}" segment="{{true}}" | ||
| selected="{{[schema.wordLayerId]}}" | ||
| selected="{{[schema.utteranceLayerId, schema.wordLayerId]}}" |
There was a problem hiding this comment.
The reason it's not selected by default is that all formats that need the utterance layer to make sense should load it anyway.
Have you found that's not the case?
There was a problem hiding this comment.
It is the case. I like having it preselected because (1) that communicates that it'll be exported by default for formats that need it, (2) it's a sensible default. But I'm happy to revert for upstream if you'd like!
| if (!this.showAttributesSelection) { // show options | ||
| this.showAttributesSelection = true; | ||
| } else { // options selected, so go ahead and do it | ||
| if (this.selectedIds.length == 0 && this.matchCount > 10) { |
There was a problem hiding this comment.
How about upping the limit instead? There are some very large LaBB-CAT corpora out there for which accidentally starting an export of everything would be problematic.
So maybe this.matchCount > 1000 instead?
…rt but with much higher limit (PR nzilbb#104)
No worries, as long as you've tested it - when I tried to do it that way, it worked until I ticked checkboxes, and then the button enabled again and gave en error when pressed. |
|
Here's the behavior I'm seeing in this branch:
Are you seeing something different? |
|
This is in APLS-Dev, for what it's worth. |
|
Turns out the error I was seeing was because I ticked all the checkboxes (there was only one) - this leads to an error when clicking List Transcripts but I've just pushed a fix for that. |
2 participants
No description provided.