Skip to content

Fix OpenAPI Spec Discrepancy#228

Merged
o-ga09 merged 1 commit intomainfrom
fix-openapi-spec-discrepancy-2665827370005928454
Apr 9, 2026
Merged

Fix OpenAPI Spec Discrepancy#228
o-ga09 merged 1 commit intomainfrom
fix-openapi-spec-discrepancy-2665827370005928454

Conversation

@o-ga09
Copy link
Copy Markdown
Owner

@o-ga09 o-ga09 commented Apr 9, 2026

closes #225

Resolved discrepancies between the OpenAPI specification and the actual implementation by aligning the Gin router, updating Go annotations in the handlers, and regenerating the Swagger documentation. Outdated and conflicting specification files were removed, and relevant tests were updated and verified.


PR created automatically by Jules for task 2665827370005928454 started by @o-ga09

- Update Gin router in `internal/presenter/server.go` to use consistent path parameter names (`:itemId`, `:monsterId`).
- Add and correct Swagger annotations in `monster`, `item`, and `system` handlers.
- Update `makefile` to include all controllers in `swag init` and generate both YAML and JSON.
- Regenerate OpenAPI documentation files.
- Remove outdated `openapi.json` and `schema.yml`.
- Update `internal/controller/item/handler_test.go` to match the new route structure.

Co-authored-by: o-ga09 <54522966+o-ga09@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
27.9% 1:0.4 1m20s

Code coverage of files in pull request scope (60.1%)

Files Coverage
internal/controller/item/handler.go 78.7%
internal/controller/monster/handler.go 91.7%
internal/controller/system.go 0.0%
internal/presenter/server.go 0.0%

Reported by octocov

@o-ga09 o-ga09 merged commit 2900918 into main Apr 9, 2026
6 checks passed
@o-ga09 o-ga09 deleted the fix-openapi-spec-discrepancy-2665827370005928454 branch April 9, 2026 14:16
@github-actions github-actions bot mentioned this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAPISpecを修正する

1 participant