add configurable sign up and update account input types#22
add configurable sign up and update account input types#22ferland182 wants to merge 12 commits intomasterfrom
Conversation
ferland182
changed the title
vfonic
left a comment
vfonic
left a comment
There was a problem hiding this comment.
I just discovered this project. It's a bit strange to see some of the bugs that are fixed in this PR. Perhaps some of these bugfixes should also have appropriate tests to ensure these bugs don't happen again in the future?
| description 'Update account arguments' | ||
|
|
||
| argument :email, String, required: true do | ||
| description "User's new password" |
There was a problem hiding this comment.
This description doesn't match with the argument name. Should this be left out of this gem completely and let the developer create custom mutation for updating non-password fields?
Or maybe this could be added to the rails app when running the install generator?
|
Hi @vfonic! Thanks for taking the time to review this PR! I think this branch is not up-to-date and need to be rebase from master where some bugs are already fixed. Could you update your PR @ferland182 ? |
|
Anyone up here to merge this feature request? |
4 participants
fix #21