Linux: Allow for conditional use of system SQLite library instead of bundled#205
Open
nicholas-rh wants to merge 2 commits intoo3de:mainfrom
Open
Linux: Allow for conditional use of system SQLite library instead of bundled#205nicholas-rh wants to merge 2 commits intoo3de:mainfrom
nicholas-rh wants to merge 2 commits intoo3de:mainfrom
Conversation
Author
|
Also just to clarify I don't intend for this to replace the sqlite O3DE package, or even be the primary supported method of linking to sqlite, but just to exist as another option for those who find it useful to reduce the amount of cmake script hacking required |
Signed-off-by: Nicholas Frizzell <nfrizzel@redhat.com>
Signed-off-by: Nicholas Frizzell <nfrizzel@redhat.com>
acc2e88 to
bf5a68f
Compare
This was referenced Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first go at an implementation of the feature request outlined here: o3de/o3de#16375
This PR allows for the user to specify to use the system sqlite library instead of the bundled statically linked version. The high-level goal here is to work towards enabling builds using the available system libraries where it makes sense and is useful. This would reduce the burden on package maintainers (and ideally the O3DE build systems/setup for Linux as well).
I tested building the install target both with the cmake variable enabled and disabled by building the sqlite package with the new find scripts included, installing them to my LY_3RDPARTY_PATH, and updating the package hash, and verified the expected behavior.
The main area which may need some extra feedback/review is the impact on monolithic & distributable builds and if there needs to be some extra logic somewhere for those, since we are dynamically linking instead of statically, and truthfully I'm not as familiar with the monolithic build workflow.