Skip to content

Remove googletest package#265

Open
mprettner-huawei wants to merge 1 commit intoo3de:mainfrom
mprettner-huawei:remove-googletest
Open

Remove googletest package#265
mprettner-huawei wants to merge 1 commit intoo3de:mainfrom
mprettner-huawei:remove-googletest

Conversation

@mprettner-huawei
Copy link

This PR removes the build scripts for the googletest package.
In O3DE PR18362 googletest is switched from prebuilt to being built from source, so this 3rdparty-package is no longer needed.
(Dont merge this before O3DE PR18362 is merged.)

Signed-off-by: Markus Prettner <markus.prettner@huawei.com>
@mprettner-huawei
Copy link
Author

Not really sure why the pipeline fails, it sais Error, package DIFF= is not in the build-from-folder list.. Maybe it is related to Googlebenchmark depending on Googletest?

@nick-l-o3de
Copy link
Contributor

I don't think we've ever actually removed a package like this before, so the auto-build system may be confused.

Copy link
Contributor

@spham-amzn spham-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to rebase this PR, but this looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants