Add support for WebAssembly builds of some 3p-packages#284
Open
guillaume-haerinck wants to merge 14 commits intoo3de:mainfrom
Open
Add support for WebAssembly builds of some 3p-packages#284guillaume-haerinck wants to merge 14 commits intoo3de:mainfrom
guillaume-haerinck wants to merge 14 commits intoo3de:mainfrom
Conversation
|
|
||
| cmake_generate_cmd = [self.cmake_command, | ||
| # emcmake self configure the proper environment when targeting WebAssembly | ||
| cmake_command = self.cmake_command |
Contributor
Author
There was a problem hiding this comment.
I am unsure about this approach, we might want to setup the same environment as emcmake is doing in the configure json file. Yet this is the easiest and lowest maintenance path so I let the build system pro decide on what is best
guillaume-haerinck
changed the title
nick-l-o3de
approved these changes
Aug 11, 2025
| @@ -1 +1,2 @@ | |||
| package-system/Crashpad/add_o3de_handler_extensions.patch eol=lf | |||
Contributor
There was a problem hiding this comment.
.gitattributes files can be in any folder, why not put this in a .gitattributes file in the same folder as the file it affects?
| "custom_additional_compile_definitions":[ | ||
| "GTEST_HAS_TR1_TUPLE=0", | ||
| "GTEST_OS_SUPPORTS_DEATH_TEST=0" | ||
| ] |
Contributor
There was a problem hiding this comment.
I'm under the impression that we now build googletest as an inline fetchcontent build, this package is unused. see Code\Framework\AzTest\3rdParty\Findgoogletest.cmake
package_build_list_host_windows.json
Outdated
| "googlebenchmark-1.7.0-rev1-windows": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googlebenchmark --platform-name Windows --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-android": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Android --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-windows": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Windows --package-root ../../package-system --clean", | ||
| "googletest-1.8.1-rev4-emscripten": "Scripts/extras/pull_and_build_from_git.py ../../package-system/googletest --platform-name Emscripten --package-root ../../package-system --clean", |
Contributor
There was a problem hiding this comment.
As above.. you can do this, but the engine doesn't use it.
Contributor
Author
|
Noted just updated the files following your feedbacks :) |
Contributor
|
This looks good, but how do we want to proceed with this, should we keep this alive while the emscripten changes happen on o3de, until its all in, or do you expect no further revisions of this package need be made? |
nick-l-o3de
approved these changes
Aug 14, 2025
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
guillaume-haerinck
force-pushed
the
emscripten
branch
from
41ca648 to
91a0674
Compare
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
guillaume-haerinck
added
the
status/ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to build several 3p package to the WebAssembly target thanks to emscripten compiler
Related to :
What remains :
How was this PR tested?
Local build on windows.
Setup required for now:
Steps:
python .\build_package.py --search_path ..\..\3p-package-source Lua-5.4.4-rev1-emscriptenemcmake cmake .. -DLY_3RDPARTY_PATH=YOUR_PATHthen build the test targets)