Use minimum effective cancellation time for KWR refunds (OZ-5)#88
Merged
Use minimum effective cancellation time for KWR refunds (OZ-5)#88
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ce3f1e9f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mahabubAlahi
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PausableCancellable
uint256 private _cancellationTimestorage variable_cancel(), added_cancellationTime = block.timestampso every cancellation records when it happenedcancellationTime()public getterKeepWhatsRaised
uint256 private s_cancellationTime— redundant now thatPausableCancellabletracks its_cancellationTime = block.timestampfromcancelTreasury()—_cancel()handles this_getEffectiveCancellationTime()— checks both the treasury’s owncancellationTime()(inherited)and
PausableCancellable(address(INFO)).cancellationTime()(campaign’s), returning the earlier of the twoif both are set, or whichever is non-zero
_checkRefundPeriodStatus(),claimTip(), andclaimFund()to use the effective cancellation timeinstead of the local-only
s_cancellationTimeThis ensures that when a campaign is cancelled (even without explicitly cancelling the treasury), refund
scheduling uses the campaign’s cancellation timestamp — backers get immediate access to refunds rather
than waiting for the original deadline.