Open
Conversation
SYNchroACK
commented
Oct 18, 2023
- Rename properties types based on the naming pattern
- Add missing _type field
Contributor
|
@chisholm - is this worth merging? |
Contributor
|
In principle, I am okay with what the changes are doing. But this doesn't appear to change type names in enough places. For example, see imports in: cti-python-stix2/stix2/v21/__init__.py Lines 26 to 35 in 6dd83fa This change breaks some of those imports. Perhaps an IDE should be used to do the refactor, to ensure the names are changed in all places they are used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.