error_explainer: normalize errors, add codes + symbol metadata#14
Open
mustafa0x wants to merge 2 commits intoobadx:mainfrom
Open
error_explainer: normalize errors, add codes + symbol metadata#14mustafa0x wants to merge 2 commits intoobadx:mainfrom
mustafa0x wants to merge 2 commits intoobadx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speech_error_typeinexplain_errorusing expected vs predicted phoneme spansexpected_lenandpredicted_lenfrom phoneme string lengthsWhy
Fallback errors could be emitted with vague or mismatched
speech_error_typeand without length detail, which makes downstream feedback unclear.Validation
python -m py_compile src/quran_transcript/phonetics/error_explainer.pypasseserror_explainer.pyScope
quran-transcript)