2X faster & represent deleted character as MappingPos(pos=(x, x), deleted=True) instead for None#7
Merged
2X faster & represent deleted character as MappingPos(pos=(x, x), deleted=True) instead for None#7
MappingPos(pos=(x, x), deleted=True) instead for None#7Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no opoperation inMappingPos.add_tajweed_ruleand doing inplace mapping instead of creating new listsMappingPos(pos=(x, x), deleted=True)instead forNonefor more clean code and representing Tajweed rules of deletions likeحذف حرف المد للاتقاء الساكنين