Skip to content

Clean up yk8 branch#28

Open
timweri wants to merge 23 commits intoyk8from
yk8-thanh
Open

Clean up yk8 branch#28
timweri wants to merge 23 commits intoyk8from
yk8-thanh

Conversation

@timweri
Copy link
Collaborator

@timweri timweri commented Apr 16, 2025

Note: The large diff is due to the inclusion of Cargo.lock.

Followed #27 and implemented our own type which implements KeyType, allowing us to avoid importing p256 and p384. However, I used spki for signature verification instead of ring.

These tests work on:

  • Firmware 5.7.1 with default 3DES management keys:
  • Firmware 5.7.2 with default AES192 management keys:
cargo run --example yk-provision --features yubikey-support -- \
  --slot R3 --subject "my-test-key" --type p384

cargo run --example yk-provision --features yubikey-support -- \
  --slot R3 --subject "my-test-key" --type p256

cargo run --example yk-generate-csr --features yubikey-support -- -s R3

@timweri timweri changed the title [WIP] Migrating from x509-parser to x509-cert Clean up yk8 branch Feb 16, 2026
.unwrap(),
AlgorithmId::EccP256,
)
(pki.subject_public_key.raw_bytes().to_vec(), AlgorithmId::EccP256)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obelisk The .to_der() is incorrect. This change makes cargo run --example yk-generate-csr --features yubikey-support -- -s R3 pass.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it cause any other use cases to fail that expected the faulty behaviour in Rustica?

@timweri timweri marked this pull request as ready for review February 16, 2026 02:19
@timweri timweri requested a review from obelisk February 16, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments