FileAttachment.csv({typed: "auto"})#169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adapted from the table cell implementation, but whereas that (for reasons that I cannot recall or imagine) attempted to infer types from arbitrary types, we only need to infer types from strings (CSV or TSV), significantly reducing complexity. We likewise don’t need to distinguish between integers and numbers because the coercion behavior is the same. Also, we don’t need
getAllKeysbecause we will always have column names provided by d3-dsv… although I’m not sure whattyped: "auto"should do when parsing rows?