Monoid subclasses - #56
Open
endgame wants to merge 3 commits into
Open
Conversation
The implementations of these instances are inspired by the ones from `Data.Map.Lazy`.
Contributor
Author
|
Has anyone had a chance to look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #55, so you can merge that first in case you want to ship that before a release with new features.
reflex-frp/patch#44 is the grand plan to get
patch-ish things offDecideablyEmptyand useMonoidNullfrommonoid-subclasses. Since this PR adds the dep anyway, I filled out all the lawful instances that I could.Note that there's no instance for
LeftGCDMonoid (DMap k f); unlikecontainers,dependent-mapdoes not provide amergeWithKeyfunction. I can add one, if you'd like, and add the instance in this PR.