Skip to content

libobs: Create unique groups when duplicating scene - #11092

Open
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:fix-groups
Open

libobs: Create unique groups when duplicating scene#11092
Warchamp7 wants to merge 1 commit into
obsproject:masterfrom
Warchamp7:fix-groups

Conversation

@Warchamp7

@Warchamp7 Warchamp7 commented Aug 8, 2024

Copy link
Copy Markdown
Member

Description

Updates obs_scene_duplicate to always duplicate groups within the duplicated scene.

This fixes the weird behavior of groups in Studio Mode when Duplicate Scenes is ON and Duplicate Sources is OFF (These are the default settings)

Motivation and Context

Studio mode allows users to modify a scene without the changes happening live in Program.

Since we default to Duplicate Scenes enabled and Duplicate Sources disabled, sources that are nested in a scene (or a group) still have their changes reflected immediately in program. In some cases, this is desirable behavior.

However, this has two drawbacks.

  1. The size and position of a group updates based on its contents. This leads to extremely unpredictable behavior for groups with Studio Mode enabled on the default settings, as the groups size and position effectively desyncs
  2. Most users don't realize that groups are scenes, and not a UI abstraction, meaning the nested scene behavior is usually confusing and undesirable

How Has This Been Tested?

Adjusted the size and position of a group as well as it's contents in normal mode and studio mode.

Tested with all combinations of Duplicate Scenes and Duplicate Sources ON and OFF

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Aug 10, 2024
@Warchamp7
Warchamp7 marked this pull request as ready for review June 8, 2026 18:34
@Warchamp7

Copy link
Copy Markdown
Member Author

This PR was originally Drafted due to duplicating a scene causing any groups in it to be created as duplicates rather than references.

However since this PR, our envisioned UX around groups has changed to prefer duplication and the new add source flow actively discourages group references.

Situations where users want a collection of sources that can be referenced in multiple places and updated once should use Scenes as sources and improvements around that workflow are planned. Groups should remain as strictly an organizational tool within a particular scene.

@Warchamp7 Warchamp7 added the release-note/change Groups pull request under the "Changes" section in the associated patch notes label Jun 8, 2026
@github-project-automation github-project-automation Bot moved this to Ready For Review in 33.0 Release Tracker Jun 16, 2026
@Warchamp7 Warchamp7 added this to the OBS Studio 33.0 milestone Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. release-note/change Groups pull request under the "Changes" section in the associated patch notes

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

2 participants