linux-alsa: Fix use-after-free crash when USB mic not plugged in - #11608
Open
R0te wants to merge 1 commit into
Open
linux-alsa: Fix use-after-free crash when USB mic not plugged in#11608R0te wants to merge 1 commit into
R0te wants to merge 1 commit into
Conversation
kkartaltepe
approved these changes
Dec 9, 2024
Collaborator
|
Volatile variables should probably be used with the atomic functions. And if the other volatiles aren't being used with atomic operations, they probably should be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a use-after-free crash in the ALSA input plugin that occurs when creating a new scene collection without the previously configured USB microphone plugged in. A shutdown flag is introduced to safely coordinate the termination of background threads and prevent access to freed resources.
Motivation and Context
Previously,
_alsa_reopen()could run concurrently afteralsa_destroy()freed the device string or other resources, causing a heap-use-after-free crash. This fix ensures that background threads properly exit when the source is destroyed, eliminating the race condition.#9322
How Has This Been Tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: