Skip to content

win-capture: Change WGC capture method name - #12047

Open
Penwy wants to merge 2 commits into
obsproject:masterfrom
Penwy:wgc-naming
Open

win-capture: Change WGC capture method name#12047
Penwy wants to merge 2 commits into
obsproject:masterfrom
Penwy:wgc-naming

Conversation

@Penwy

@Penwy Penwy commented Apr 12, 2025

Copy link
Copy Markdown
Contributor

Description

this changes the localised name of the WGC capture method for display and window capture from Windows 10 (1903 and up) to WGC (Windows 10 1903 and up).

Motivation and Context

Naming the method "Windows 10" frequently confuses users that are on windows 11 and think that, as such, it cannot apply to them. This issue will only worsen with time.
The API itself is named "Windows Graphics Capture" so I see no sufficient reason not to use that name.

How Has This Been Tested?

Hasn't.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Apr 12, 2025
@Fenrirthviti

Copy link
Copy Markdown
Member

I might even be in favor of dropping the part in parenthesis altogether (as those build numbers are typically meaningless to most users). Defer to Warchamp's thoughts though.

@Fenrirthviti Fenrirthviti added area/ui-ux Anything to do with changes or additions to UI/UX elements. and removed kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Apr 12, 2025
@notr1ch

notr1ch commented Apr 13, 2025

Copy link
Copy Markdown
Member

The 22H2 as opposed to build number might make more sense as the YYMM format hasn't been used for quite a while. Would it be possible to use "Windows Graphics Capture" and if the user is on an unsupported OS, append " (unavailable, outdated OS)".

@Penwy

Penwy commented Apr 13, 2025

Copy link
Copy Markdown
Contributor Author

That is very much possible, but to note is that the list item is already disabled when not supported.
https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/window-capture.c#L540

@Lain-B

Lain-B commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

I'd agree the naming needs to be better, what it should be instead is up for debate. @Warchamp7 what do you think?

@Penwy

Penwy commented Apr 27, 2025

Copy link
Copy Markdown
Contributor Author

As I see it there's mainly two questions :

  • Whether to call it WGC or Windows Graphic Capture.
  • Whether to drop the version number (and drop it for BitBlt too) or keep it.

@Warchamp7

Copy link
Copy Markdown
Member

My vote would be for us to rename both options to Modern (WGC) and Legacy (BitBlt), and also if possible adjust the order to be Automatic, Modern, Legacy

Tangential question: Does the WGC option show up in the list for people on a version earlier than 1903? If so, is it possible for us to hide the option for those people?

@Lain-B

@Penwy

Penwy commented May 25, 2025

Copy link
Copy Markdown
Contributor Author

@Warchamp7 If WGC is not available (for example if on a version of windows too old for it) the option is added to the list but disabled.
https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/window-capture.c#L540

I agree with the suggested name changes, and committed them.

@RytoEX
RytoEX requested a review from Fenrirthviti June 26, 2026 18:39
@RytoEX RytoEX added this to the OBS Studio 33.0 milestone Jun 26, 2026
@github-project-automation github-project-automation Bot moved this to Ready For Review in 33.0 Release Tracker Jun 26, 2026
@Warchamp7 Warchamp7 moved this from Ready For Review to Ready For Merge in 33.0 Release Tracker Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements.

Projects

Status: Ready For Merge

Development

Successfully merging this pull request may close these issues.

7 participants