frontend: Fix memory leak with --disable-missing-files-check

[fzwoch]

The missing files dialog takes responsibility of freeing the missing files list. When --disable-missing-files-check is used we need to drop this object or we leak it.

Someone reported this on Discord.

Description

Fixes some memory leak when --disable-missing-files-check is being used.

Motivation and Context

From a report from Discord. When --disable-missing-files-check is being used the memory checker reports one block of memory being leaked when OBS is shut down.

How Has This Been Tested?

Run with --disable-missing-files-check. Memory leak counter returns to 0.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[RytoEX]

A different attempt at fixing this is #11075.

cc @PatTheMav since he gave feedback on that one. Would like to know if either approach is acceptable.

[PatTheMav]

A different attempt at fixing this is #11075.

cc @PatTheMav since he gave feedback on that one. Would like to know if either approach is acceptable.

My gut reaction is to prefer #11075 as that one avoids allocating memory in the first place.

[RytoEX]

My gut reaction is to prefer #11075 as that one avoids allocating memory in the first place.

Someone will probably have to adopt that one and bring it over the finish line.