Skip to content

libobs: Fix canvas private duplicated scenes - #12824

Open
exeldro wants to merge 1 commit into
obsproject:masterfrom
exeldro:fix_canvas_duplicate_private
Open

libobs: Fix canvas private duplicated scenes#12824
exeldro wants to merge 1 commit into
obsproject:masterfrom
exeldro:fix_canvas_duplicate_private

Conversation

@exeldro

@exeldro exeldro commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Description

Fix calling obs_scene_duplicate with OBS_SCENE_DUP_PRIVATE_REFS not setting canvas

Motivation and Context

When you use studio mode with duplicate scene you get this warning in the OBS log file:
Attempted to add Scene without specifying a canvas! Using default canvas instead.

How Has This Been Tested?

On windows by enabling studio mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Nov 15, 2025
@Fenrirthviti

Copy link
Copy Markdown
Member

Does this actually have any negative effects outside the log line? I agree it should probably be fixed even if so, but curious what the presenting bug is, if any here to help prioritize it.

@exeldro

exeldro commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

If you have OBS without any plugins that create an extra canvas there is a log line every scene switch when in studio mode. For extra canvas the duplication will get the resolution of the main canvas instead of the resolution the canvas the scene is duplicated from,

@Warchamp7 Warchamp7 added the kind/cleanup Non-breaking change which makes code smaller or more readable label May 26, 2026
@Warchamp7 Warchamp7 added this to the OBS Studio 33.0 milestone Jul 6, 2026
@github-project-automation github-project-automation Bot moved this to Ready For Review in 33.0 Release Tracker Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Non-breaking change which makes code smaller or more readable

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

4 participants