libobs: Fix canvas private duplicated scenes - #12824
Open
exeldro wants to merge 1 commit into
Open
Conversation
Member
|
Does this actually have any negative effects outside the log line? I agree it should probably be fixed even if so, but curious what the presenting bug is, if any here to help prioritize it. |
Contributor
Author
|
If you have OBS without any plugins that create an extra canvas there is a log line every scene switch when in studio mode. For extra canvas the duplication will get the resolution of the main canvas instead of the resolution the canvas the scene is duplicated from, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix calling obs_scene_duplicate with OBS_SCENE_DUP_PRIVATE_REFS not setting canvas
Motivation and Context
When you use studio mode with duplicate scene you get this warning in the OBS log file:
Attempted to add Scene without specifying a canvas! Using default canvas instead.How Has This Been Tested?
On windows by enabling studio mode
Types of changes
Checklist: