Skip to content

libobs: Add module version number to Windows crash handler #13190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exeldro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libobs: Add module version number to Windows crash handler #13190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions libobs/obs-win-crash-handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,24 @@ static BOOL CALLBACK enum_all_modules(PCTSTR module_name, DWORD64 module_base, U
dstr_copy(&data->module_name, name_utf8);
strlwr(data->module_name.array);
}

struct win_version_info ver = {0};
if (get_dll_ver(module_name, &ver)) {

@notr1ch notr1ch Mar 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_dll_ver calls bmalloc which is unsafe to use in a crashing path (crash could be due to OOM).

@exeldro exeldro Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dstr calls in this function also use brealloc, should that all be refactored? And if so that would be something for a separate pull request in my opinion.

#ifdef _WIN64
dstr_catf(&data->module_list, "%016" PRIX64 "-%016" PRIX64 " %s (%d.%d.%d.%d)\r\n", module_base,
module_base + module_size, name_utf8, ver.major, ver.minor, ver.build, ver.revis);
#else
dstr_catf(&data->module_list, "%08" PRIX64 "-%08" PRIX64 " %s (%d.%d.%d.%d)\r\n", module_base,
module_base + module_size, name_utf8, ver.major, ver.minor, ver.build, ver.revis);
#endif
} else {
#ifdef _WIN64
dstr_catf(&data->module_list, "%016" PRIX64 "-%016" PRIX64 " %s\r\n", module_base, module_base + module_size,
name_utf8);
dstr_catf(&data->module_list, "%016" PRIX64 "-%016" PRIX64 " %s\r\n", module_base,
module_base + module_size, name_utf8);
#else
dstr_catf(&data->module_list, "%08" PRIX64 "-%08" PRIX64 " %s\r\n", module_base, module_base + module_size,
name_utf8);
dstr_catf(&data->module_list, "%08" PRIX64 "-%08" PRIX64 " %s\r\n", module_base,
module_base + module_size, name_utf8);
#endif
}
return true;
}

Expand Down