frontend: Update invokeMethod to use function pointers - #13344
Open
Warchamp7 wants to merge 1 commit into
Open
Conversation
Warchamp7
force-pushed
the
remove-string-invokes
branch
from
April 20, 2026 20:58
bc279ba to
1abf29d
Compare
Warchamp7
added
the
kind/cleanup
Warchamp7
force-pushed
the
remove-string-invokes
branch
2 times, most recently
from
July 15, 2026 18:44
b3d8afa to
a2170fb
Compare
Warchamp7
changed the title
Warchamp7
force-pushed
the
remove-string-invokes
branch
from
July 21, 2026 19:26
a2170fb to
a1efe78
Compare
Warchamp7
force-pushed
the
remove-string-invokes
branch
from
July 21, 2026 19:26
a1efe78 to
267096d
Compare
PatTheMav
reviewed
Aug 7, 2026
| } else { | ||
| QMetaObject::invokeMethod(main, "SetCurrentScene", WaitConnection(), Q_ARG(OBSSource, OBSSource(scene)), | ||
| Q_ARG(bool, false)); | ||
| QMetaObject::invokeMethod(main, qOverload<OBSSource, bool>(&OBSBasic::SetCurrentScene), |
Member
Author
There was a problem hiding this comment.
OBSBasic has two functions named SetCurrentScene.
void SetCurrentScene(obs_scene_t *scene, bool force = false);
void SetCurrentScene(OBSSource scene, bool force = false);qOverload is for resolving it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates all frontend uses of
invokeMethodwith function pointers or lambdas.Important
This PR is blocked until we drop support for Ubuntu 24.04 as this style of calling invokeMethod is not supported on Qt 6.5
Motivation and Context
Makes it easier to update or refactor code without having to worry about string references to slot functions.
How Has This Been Tested?
Compiled OBS and performed a few basic tests. I have not tested thoroughly yet.
Types of changes
Checklist: