Skip to content

obs-qsv11: Fix CQP values in encoder log - #13747

Open
omarr-ka wants to merge 1 commit into
obsproject:masterfrom
omarr-ka:fix-qsv-cqp-log
Open

obs-qsv11: Fix CQP values in encoder log#13747
omarr-ka wants to merge 1 commit into
obsproject:masterfrom
omarr-ka:fix-qsv-cqp-log

Conversation

@omarr-ka

@omarr-ka omarr-ka commented Aug 3, 2026

Copy link
Copy Markdown

Log the separate QPI, QPB, and QPP settings for encoder version 1 and the shared CQP setting for version 2.

Description

QSV encoder version 2 uses a single CQP setting, but the encoder log
currently prints the unused legacy QPI, QPB, and QPP settings. These
retain their default value of 23 regardless of the configured CQP
value.

Motivation and Context

The current log output suggests that the configured CQP value is not
being applied, even though recordings made with different CQP values
show that the encoder does use the selected setting.

For example, recordings configured with CQP 12 and CQP 30 both report
QPI, QPB, and QPP as 23 in the log despite producing substantially
different file sizes.

How Has This Been Tested?

The existing incorrect log behavior was reproduced with QuickSync
H.264 CQP recordings on Windows.

This change has been reviewed against the version-specific settings
paths but has not yet been runtime-tested in a locally built OBS
version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Log the separate QPI, QPB, and QPP settings for encoder version 1 and the shared CQP setting for version 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant