obs-qsv11: Fix CQP values in encoder log - #13747
Open
omarr-ka wants to merge 1 commit into
Open
Conversation
Log the separate QPI, QPB, and QPP settings for encoder version 1 and the shared CQP setting for version 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log the separate QPI, QPB, and QPP settings for encoder version 1 and the shared CQP setting for version 2.
Description
QSV encoder version 2 uses a single CQP setting, but the encoder log
currently prints the unused legacy QPI, QPB, and QPP settings. These
retain their default value of 23 regardless of the configured CQP
value.
Motivation and Context
The current log output suggests that the configured CQP value is not
being applied, even though recordings made with different CQP values
show that the encoder does use the selected setting.
For example, recordings configured with CQP 12 and CQP 30 both report
QPI, QPB, and QPP as 23 in the log despite producing substantially
different file sizes.
How Has This Been Tested?
The existing incorrect log behavior was reproduced with QuickSync
H.264 CQP recordings on Windows.
This change has been reviewed against the version-specific settings
paths but has not yet been runtime-tested in a locally built OBS
version.
Types of changes
Checklist: