Skip to content

libobs: Fix color space query through non-video filters - #13761

Open
saitatter wants to merge 1 commit into
obsproject:masterfrom
saitatter:fix-color-space-nonvideo-filters
Open

libobs: Fix color space query through non-video filters#13761
saitatter wants to merge 1 commit into
obsproject:masterfrom
saitatter:fix-color-space-nonvideo-filters

Conversation

@saitatter

@saitatter saitatter commented Aug 6, 2026

Copy link
Copy Markdown

Description

This change fixes HDR color space identification when multiple filters are added to a source in different orders. Previously, if an audio filter was added before the HDR tonemapping override filter, the color space could be identified incorrectly and the HDR tonemapping filter would be skipped.

Motivation and Context

I ran into this while streaming and investigating why HDR tonemapping was not being applied consistently. After reproducing the issue from a clean build, I found that the filter order affected HDR source detection: adding an audio filter first and then the HDR tonemapping override filter could cause the wrong color space to be returned, which prevented the HDR filter from applying.

How Has This Been Tested?

I tested the behavior before and after the change using the HDR tonemapping filter. It now applies correctly regardless of whether audio or video filters were added first.

Tested on Windows 11 x64.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant