libobs: Fix color space query through non-video filters - #13761
Open
saitatter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes HDR color space identification when multiple filters are added to a source in different orders. Previously, if an audio filter was added before the HDR tonemapping override filter, the color space could be identified incorrectly and the HDR tonemapping filter would be skipped.
Motivation and Context
I ran into this while streaming and investigating why HDR tonemapping was not being applied consistently. After reproducing the issue from a clean build, I found that the filter order affected HDR source detection: adding an audio filter first and then the HDR tonemapping override filter could cause the wrong color space to be returned, which prevented the HDR filter from applying.
How Has This Been Tested?
I tested the behavior before and after the change using the HDR tonemapping filter. It now applies correctly regardless of whether audio or video filters were added first.
Tested on Windows 11 x64.
Types of changes
Checklist: