cmake: Use 'CMAKE_OBJDUMP' instead of 'objdump' directly - #13763
Open
Chiitoo wants to merge 1 commit into
Open
Conversation
This makes the calls more environment-friendly, and the finders more consistent-like, although before this, only 'Findqrcodegencpp.cmake' used the variable form. Downstream-bug: https://bugs.gentoo.org/946059 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make use of 'CMAKE_OBJDUMP' instead of calling the 'objdump' executable directly.
Motivation and Context
This makes the calls to 'objdump' more environment-friendly, and the finders more consistent-like, although before this, only 'Findqrcodegencpp.cmake' used the variable form.
Downstream-bug: https://bugs.gentoo.org/946059
How Has This Been Tested?
Compiled with the change on Gentoo Linux at 'git master' on 'amd64', and '32.2.0' on 'arm64' machines.
Types of changes
Checklist: