UI: Add HotkeyBlocker class - #9981
Closed
cg2121 wants to merge 1 commit into
Closed
Conversation
6 tasks
cg2121
force-pushed
the
hotkey-blocker
branch
3 times, most recently
from
December 10, 2023 03:55
d8e5455 to
ad7f35f
Compare
cg2121
marked this pull request as draft
December 10, 2023 11:23
Contributor
Author
|
Converted to draft, as I need to figure out why it doesn't compile on Windows and macOS. |
Contributor
Author
|
#9989 should fix the compiling issue, so that one needs to be merged first. |
cg2121
force-pushed
the
hotkey-blocker
branch
from
December 11, 2023 12:35
ad7f35f to
40a40e0
Compare
This adds a HotkeyBlocker class that is similar to SignalBlocker. It is used when selection dialogs are opened and because they are modal, hotkeys shouldn't be able to be used.
Contributor
Author
|
Found a way to accomplish this in #7924 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a HotkeyBlocker class that is similar to SignalBlocker. It is used when selection dialogs are opened and because they are modal, hotkeys shouldn't be able to be used.
Motivation and Context
Simpler alternative to #8725
Fixes #7824
How Has This Been Tested?
Opened file dialog from image context bar widget and made sure hotkeys were disabled when browsing and re-enabled when it was closed.
Types of changes
Checklist: