fix(trace): use microseconds for chrome trace timestamps#13911
Merged
Alizter merged 4 commits intoocaml:mainfrom Mar 25, 2026
Merged
fix(trace): use microseconds for chrome trace timestamps#13911Alizter merged 4 commits intoocaml:mainfrom
Alizter merged 4 commits intoocaml:mainfrom
Conversation
Chrome Trace Event Format requires timestamps in microseconds, but json_of_event was emitting seconds (regression from c01c7d1). Convert from nanoseconds using integer division (to_ns / 1000) for both ts and dur fields in chrome mode. Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
reviewed
Mar 25, 2026
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
approved these changes
Mar 25, 2026
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
Thanks. A CHANGES entry would be appropriate as well.
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-nlsmlklkoxsm
branch
from
0f98dd1 to
35a6f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome Trace Event Format requires timestamps in microseconds, but
json_of_eventwas emitting seconds. We therefore now convert for both thetsanddurfields in chrome trace mode.dune trace cat --chrome-tracehas wrong timing units #13906