Skip to content

Fix sites plugin test #15224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paurkedal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sites plugin test #15224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f10fe0
Fix sites-plugin test (1/2): Make the problem visible
paurkedal Jun 17, 2026
19fad0c
Fix sites-plugin test (2/2): Split package tar file.
paurkedal Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 48 additions & 4 deletions test/blackbox-tests/test-cases/pkg/sites-plugin.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,17 @@ Make an executable using dune-site (example mostly from the manual)
Registration of Plugin1
Main app starts...
Plugin1 is doing something...
$ tar cf ../plugin.tar plugin
$ cd ..
$ tar cf app.tar app
$ rm -rf app

Configure our fake curl to serve the tarball:

$ echo app.tar >> fake-curls
$ PORT=1
$ APP_PORT=1
$ echo plugin.tar >> fake-curls
$ PLUGIN_PORT=2

Make a package for the executable and the plugin:
$ mkpkg app <<EOF
Expand All @@ -53,7 +56,7 @@ Make a package for the executable and the plugin:
> ]
> ]
> url {
> src: "http://0.0.0.0:$PORT"
> src: "http://0.0.0.0:$APP_PORT"
> checksum: [
> "md5=$(md5sum app.tar | cut -f1 -d' ')"
> ]
Expand All @@ -72,9 +75,9 @@ Make a package for the executable and the plugin:
> ]
> ]
> url {
> src: "http://0.0.0.0:$PORT"
> src: "http://0.0.0.0:$PLUGIN_PORT"
> checksum: [
> "md5=$(md5sum app.tar | cut -f1 -d' ')"
> "md5=$(md5sum plugin.tar | cut -f1 -d' ')"
> ]
> }
> EOF
Expand Down Expand Up @@ -116,3 +119,44 @@ Registration of Plugin1
Main app starts...
Plugin1 is doing something...
```

So, what went wrong? The findlib library is now available:

$ dune exec ocamlfind query plugin1.plugin1_impl | censor
$PWD/_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST/target/lib/plugin1/plugin1_impl

And the files have been installed, though maybe the app/plugins directory needs
to be located under the same target directory?

$ find _build -path '*/target/*' | sort | censor
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/bin
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/bin/app
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/cookie
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/META
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/dune-package
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/register
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/register/registration.cma
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/register/registration.cmi
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/register/registration.cmt
_build/_private/default/.pkg/app.0.0.1-$DIGEST1/target/lib/app/register/registration.ml
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/cookie
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/app
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/app/plugins
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/app/plugins/plugin1
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/app/plugins/plugin1/META
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/META
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/dune-package
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/opam
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.a
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cma
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cmi
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cmt
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cmx
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cmxa
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.cmxs
_build/_private/default/.pkg/plugin1.0.0.1-$DIGEST2/target/lib/plugin1/plugin1_impl/plugin1_impl.ml
Loading