Skip to content

show env: accept absolute workspace paths #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pushkarscripts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

show env: accept absolute workspace paths #15296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bin/printenv.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ let term =
Build.build_memo_exn (fun () ->
let open Memo.O in
let* setup = Util.setup () in
let dir = Path.of_string dir in
let dir =
Path.of_string dir
|> Path.Expert.try_localize_external
in
let checked = Util.check_path setup.contexts dir in
let request =
Action_builder.all
Expand Down
14 changes: 6 additions & 8 deletions test/blackbox-tests/test-cases/absolute-paths/show-env-absolute.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,22 @@ work identically to the relative form. Today it errors as if the path were
outside the project.

$ dune show env $PWD --field flags
Error: Environment is not defined for external paths
[1]
(flags
(-short-paths -keep-locs -warn-error +a -w +27))

CR-someday Alizter: the same call from a subdirectory should also resolve.
(--root is required because INSIDE_DUNE disables workspace auto-detection.)

@Alizter Alizter Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prose needs to be updated now that the test is exhibiting the correct behaviour.


$ (cd subdir && dune show env --root .. $PWD --field flags)
Entering directory '..'
Error: Environment is not defined for external paths
Leaving directory '..'
[1]
(flags
(-short-paths -keep-locs -warn-error +a -w +27))

CR-someday Alizter: absolute paths to subdirectories of the workspace
should be accepted.

$ dune show env $PWD/subdir --field flags
Error: Environment is not defined for external paths
[1]
(flags
(-short-paths -keep-locs -warn-error +a -w +27))

Absolute paths that are genuinely outside the workspace must continue to
fail with a clean error. This behaviour must not regress.
Expand Down
Loading