Use same compiler settings for .#dune and .#dune-static#15408
Draft
Leonidas-from-XIV wants to merge 1 commit into
Draft
Use same compiler settings for .#dune and .#dune-static#15408Leonidas-from-XIV wants to merge 1 commit into
.#dune and .#dune-static#15408Leonidas-from-XIV wants to merge 1 commit into
Conversation
The nix-overlay enables `flambda` automatically and in the flake we disable it for `dune`, instead enabling frame pointers. However, this is not the case for `dune-static`, where we use the regular `ocaml` package (from the overlay) which uses `flambda` but no frame pointers. This applies the same compiler configuration to `dune-static` as to `dune`. Signed-off-by: Marek Kubica <marek@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nix-overlay enables
flambdaautomatically and in the flake we disable it fordune, instead enabling frame pointers. However, this is not the case fordune-static, where we use the regularocamlpackage (from the overlay) which usesflambdabut no frame pointers.This applies the same compiler configuration to
dune-staticas todune.