Skip to content

Use grep CLI in a portable way#1453

Merged
jonludlam merged 1 commit into
ocaml:masterfrom
Leonidas-from-XIV:openbsd-grep-again
Jul 1, 2026
Merged

Use grep CLI in a portable way#1453
jonludlam merged 1 commit into
ocaml:masterfrom
Leonidas-from-XIV:openbsd-grep-again

Conversation

@Leonidas-from-XIV

@Leonidas-from-XIV Leonidas-from-XIV commented Jul 1, 2026

Copy link
Copy Markdown
Member

OpenBSD keeps failing, because BSD grep can't take grep <term> <options> but needs grep <options> term. This PR fixes the failures. Also the -A -B, -C options don't accept spaces.

Followup to #1442.

@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as ready for review July 1, 2026 09:02
@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Jul 1, 2026
@jonludlam

Copy link
Copy Markdown
Member

Nice thanks!

@jonludlam jonludlam merged commit 9c6f29e into ocaml:master Jul 1, 2026
11 of 12 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the openbsd-grep-again branch July 2, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This pull request does not need a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants