fix: teach the extension about the new remotes config key - #3
Draft
ocauapaz wants to merge 1 commit into
Draft
Conversation
The compiler grew a `remotes` key, but the extension's two copies of the key list did not follow: completion stopped offering it, and the grammar flagged it as a typo in any schema that set it. CI caught the first. The grammar was unchecked because only the example schema is tokenised, and it does not set every key, so add a case per compiler key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011WxNANvAqPzmAA4ws5FCcR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
VS Code extensionjob on CI #11 (7b5df1d, main).What broke
8cd4468added aremotesconfig key to the compiler. The extension keeps its own copies of that key list, and neither followed:src/language.js— the completion list. Theconfig key 'remotes' is documentedtest failed, which is the CI failure.syntaxes/btyn.tmLanguage.json— the highlighting regex. Not caught by any test, but a key missing from that alternation falls through to the "unknown key" rule, soremotes = "..."was rendered as a typo in every schema that set it.Changes
remotestoCONFIG_KEYSinsrc/language.js, with the default ("BTYN") and a hover doc matching the compiler's comment.remotesto the config-key alternation in the grammar.CONFIG_KEYShighlights assupport.type.property-name. The grammar was only exercised againstexamples/net.btyn, which does not use every key — that is why this one slipped through while the completion list was checked.Verification
npm testineditors/vscode: 65 passed inlanguage.test.js(was 1 failed, 63 passed) and 60 passed ingrammar.test.js. Reverting just the grammar line fails the new per-key case, so the test does catch the gap it was written for.No compiler changes — the
Compiler and codecsjob was already green.Generated by Claude Code