Add references and @deprecated support to OcsfProfile#38
Merged
Add references and @deprecated support to OcsfProfile#38
Conversation
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
Signed-off-by: Rajas Panat <rajaspa@amazon.com>
zschmerber
approved these changes
May 1, 2026
rmouritzen-splunk
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the references and @deprecated properties to the OcsfProfile type definition to fix a failing unrecognized key check. The profile metaschema (profile.schema.json) already defines both properties, but the validator's OcsfProfile TypedDict was missing them, causing the "no unknown keys" check to fail when a profile uses references.
Converted OcsfProfile from class-based TypedDict to functional form (consistent with OcsfObject and OcsfEvent) since @deprecated is not a valid Python identifier.
Bumps version to 0.2.4.
Related to ocsf/ocsf-schema#1616
--
Tested locally, runs as expected.