Conversation
Output string fixes: - html_f.ml: a_reversed emitted "reserved" instead of "reversed" - html_f.ml: a_srclang emitted "xml:lang" instead of "srclang" - html_f.ml: string_of_sandbox_token emitted "allow-script" instead of "allow-scripts" - svg_f.ml: a_zoomAndPan emitted "zoomAndSpan" instead of "zoomAndPan" - svg_f.ml: a_requiredExtensions emitted "requiredExtension" (missing s) - svg_f.ml: a_externalRessourcesRequired emitted misspelled attribute name - svg_f.ml: a_edgeMode emitted "targetY" instead of "edgeMode" - svg_f.ml: a_filterRes emitted "filterResUnits" instead of "filterRes" - svg_f.ml: a_target emitted "xlink:target" instead of "target" - svg_f.ml: font_face_format emitted "font-face-uri" instead of "font-face-format" - svg_f.ml: a_glyph_name emitted "glyphname" instead of "glyph-name" - svg_f.ml: string_of_in_value used wrong case (sourceGraphic vs SourceGraphic) - svg_f.ml: `Align mapped to "" instead of "align" - svg_f.ml: colorimetric values used underscores instead of hyphens - svg_f.ml: string_of_dominant_baseline missing hyphens in 5 values Phantom type fixes in svg_sigs.mli: - a_edgeMode, a_preserveAlpha returned `TargetY (copy-paste error) - a_filterRes returned `FilterResUnits instead of `FilterRes - a_target returned `Xlink_target instead of `Target - a_glyph_name returned `glyphname instead of `GlyphName - a_arabic_form returned `Arabicform instead of `ArabicForm - a_requiredExtensions returned `RequiredExtension (missing s) - a_xlink_title returned `Title instead of `Xlink_title - a_low returned `High instead of `Low in html_sigs.mli Type tag typos: - svg_sigs.mli: `Rendering_Indent -> `Rendering_Intent - svg_sigs.mli: `ZoomAndSpan -> `ZoomAndPan - svg_sigs.mli: `ExternalRessourcesRequired -> `ExternalResourcesRequired - svg_types.mli: `ZoomAndPlan -> `ZoomAndPan - svg_types.mli: `PreserveAspectRadio -> `PreserveAspectRatio - svg_types.mli: fefuncg/fefuncb/fefuncr all incorrectly defined as `FeFuncA - svg_types.mli: `Animate_Color -> `AnimateColor in stop_content - svg_types.mli: `ColorProfile -> `Color_Profile in colorprofile - svg_types.mli: `Missing_glyph -> `MissingGlyph in container_element - svg_types.mli: `glyphRef -> `GlyphRef in altglyphitem_content - svg_types.mli: `Bever -> `Bevel in stroke-linejoin variant - html_types.mli: `OneBeforeUnload -> `OnBeforeUnload - html_types.mli: `Autofcus -> `Autofocus - html_types.mli: missing space between `Map and `Mark Function name fixes: - svg_sigs.mli, svg_f.ml: a_baseFrenquency -> a_baseFrequency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large PR generated by claude AI assistant, that fixes many typos and copy-pasted errors
Output string fixes:
Phantom type fixes in svg_sigs.mli:
FilterResUnits instead ofFilterResXlink_target instead ofTargetglyphname instead ofGlyphNameArabicform instead ofArabicFormTitle instead ofXlink_titleHigh instead ofLow in html_sigs.mliType tag typos:
Rendering_Indent ->Rendering_IntentZoomAndSpan ->ZoomAndPanExternalRessourcesRequired ->ExternalResourcesRequiredZoomAndPlan ->ZoomAndPanPreserveAspectRadio ->PreserveAspectRatioAnimate_Color ->AnimateColor in stop_contentColorProfile ->Color_Profile in colorprofileMissing_glyph ->MissingGlyph in container_elementglyphRef ->GlyphRef in altglyphitem_contentBever ->Bevel in stroke-linejoin variantOneBeforeUnload ->OnBeforeUnloadAutofcus ->AutofocusMap andMarkFunction name fixes: