add function to load vocabularies from the file#9
Open
MorinoseiMorizo wants to merge 2 commits intoodashi:masterfrom
Open
add function to load vocabularies from the file#9MorinoseiMorizo wants to merge 2 commits intoodashi:masterfrom
MorinoseiMorizo wants to merge 2 commits intoodashi:masterfrom
Conversation
odashi
requested changes
Feb 16, 2017
| ; If you specified the model directory here, load vocabulary from the specified model. | ||
| ; If you use this option, the vocabulary type and the vocabulary size specified above will be ignored. | ||
| ; By writing vocabulary_model=none, this option will be ignored. | ||
| vocabulary_model=none |
Owner
There was a problem hiding this comment.
This allows us not to load vocabulary from none directory. It might be better to separate switch and path options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes making vocabulary takes a lot of time (especially using BPE).
So I added the function to load vocabularies from the file.