Added Test for UrlUtils

[sonalgaud12]

This PR addresses #523 which comes under utilities class

Added Test:

• testNoHashOrParameters: Verifies file name extraction from a simple file path without parameters
• testEmptyString: Checks handling of empty input string
• testOnlyHash: Tests retrieving file name from a URL with a hash fragment
• testOnlyQueryParams: Validates file name extraction from a URL with query parameters
• testHashAndQueryParams: Ensures correct file name parsing from a URL with both hash and query parameters
• testGetIndexOfParamsNoParams: Confirms parameter index detection for URL without parameters
• testGetIndexOfParamsHash: Checks parameter index identification in a hash fragment
• testGetIndexOfQueryHash: Validates parameter index detection in query parameters
• testGetIndexOfBoth: Verifies parameter index extraction from a URL with hash and query parameters
• testGetParamsNone: Ensures no parameter extraction from a simple URL
• testGetParamsHash: Tests parameter extraction from a URL with a hash fragment
• testGetParamsQuery: Validates parameter extraction from a URL with query parameters
• testGetParamsBoth: Checks parameter extraction from a URL with both hash and query parameters

Result:

[wbrunette]

There appears to be a lot of constant strings. It is better to list them as constants at the top and then use them to separate logic from declaration of constants.

For example EMPTY_STRING = "";
URL_SEGMENT1 = "test/"

[sonalgaud12]

Thank you for the feedback, I have made the changes.

[wbrunette]

If you change the package to org.opendatakit.webkitserver.utilities you should not need to use reflection.

[sonalgaud12]

I tried this approach but encountered access errors. Even with the test in the same package name, I got the error: 'getIndexOfParameters(java.lang.String)' is not public in 'org.opendatakit.webkitserver.utilities.UrlUtils'. It cannot be accessed from outside the package.
I could add a public helper method in the UrlUtils class specifically for testing or use reflection. Please let me know if you'd like me to try a different approach for accessing the package-private method

[wbrunette]

This conversation should not be resolved because it was not resolved. Also, generally, the person doing the review resolves when it's complete.

The package you changed it to is NOT the same:
org.opendatakit.webkitserver.utilities; vs org.opendatakit.test.webkitserver.utilities;

It needs to be exactly the same: org.opendatakit.webkitserver.utilities;

As stated in the review.

[sonalgaud12]

Relocated UrlUtilsTest to match the package structure of the class under test. To allows access to package-private methods for more thorough testing.

[wbrunette]

Suggestions form last code review not fixed.

A package-private function should be available to a class in the same package.

https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html

[wbrunette]

You should not delete basictest